Skip to content

Fixed acltb test failure due to conflict with the acl input test#171

Merged
oleksandrivantsiv merged 1 commit intosonic-net:masterfrom
andriymoroz-mlnx:acltb_fix
Apr 27, 2017
Merged

Fixed acltb test failure due to conflict with the acl input test#171
oleksandrivantsiv merged 1 commit intosonic-net:masterfrom
andriymoroz-mlnx:acltb_fix

Conversation

@andriymoroz-mlnx
Copy link
Copy Markdown
Contributor

No description provided.

@oleksandrivantsiv oleksandrivantsiv merged commit af2a1fb into sonic-net:master Apr 27, 2017
zhixzhu pushed a commit to zhixzhu/sonic-mgmt that referenced this pull request May 1, 2025
…g link (HBM) card (sonic-net#171)

<!--
Please make sure you've read and understood our contributing guidelines;
https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md

Please provide following information to help code review process a bit easier:
-->
### Description of PR

for cisco-8000 chassis in packet mode, add a test to verify ecn marking at congestion points based on traffic pattern

<!--
- Please include a summary of the change and which issue is fixed.
- Please also include relevant motivation and context. Where should reviewer start? background context?
- List any dependencies that are required for this change.
-->

Summary:
Fixes # (issue)

When multiple backplane traffic flows share the same slice of a asic on long-link card and use the default VOQ (as HBM-based long-link cards operate in default VOQ mode), the XOFF threshold gets breached.

This results in an XOFF signal being generated to the Fabric port, which leads to ECN marking at the Fabric port.

However, since no actual congestion is experienced on the egress port, it does not trigger ECN marking, leading to the test case failure.

### Type of change

<!--
- Fill x for your type of change.
- e.g.
- [x] Bug fix
-->

- [ ] Bug fix
- [ ] Testbed and Framework(new/improvement)
- [ ] New Test case
 - [ ] Skipped for non-supported platforms
- [x] Test case improvement

### Back port request
- [ ] 202012
- [ ] 202205
- [ ] 202305
- [ ] 202311
- [ ] 202405
- [ ] 202411

### Approach
#### What is the motivation for this PR?

#### How did you do it?

- if ecn counter is not zero at egress port->success

- if ecn counter is zero:

- check the backplane ports on all FC - some of them should have non-zero ecn counters. pass the test else step 2

- check the backplane ports on the ingress port LC — some of them should have non-zero ecn counters. pass the test else step 3

- If the two checks above led to all zero ecn counter -

Check that the ingress ports did generate XOFF else fail the test case

#### How did you verify/test it?

Verify correctness by checking that ecn marking occurs before signaling XOFF

#### Any platform specific information?

Cisco T2

```
-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
============================================================================================================================================ PASSES =============================================================================================================================================
_______________________________________________________________________________________________________________________ test_ecn_marking_port_toggle[multidut_port_info0] _______________________________________________________________________________________________________________________
_______________________________________________________________________________________________________________________ test_ecn_marking_port_toggle[multidut_port_info1] _______________________________________________________________________________________________________________________
_______________________________________________________________________________________________________________________ test_ecn_marking_port_toggle[multidut_port_info2] _______________________________________________________________________________________________________________________
_______________________________________________________________________________________________________________________ test_ecn_marking_port_toggle[multidut_port_info3] _______________________________________________________________________________________________________________________
____________________________________________________________________________________________________________ test_ecn_marking_lossless_prio[multidut_port_info1-test_flow_percent0] _____________________________________________________________________________________________________________
____________________________________________________________________________________________________________ test_ecn_marking_lossless_prio[multidut_port_info1-test_flow_percent1] _____________________________________________________________________________________________________________
____________________________________________________________________________________________________________ test_ecn_marking_lossless_prio[multidut_port_info1-test_flow_percent2] _____________________________________________________________________________________________________________
____________________________________________________________________________________________________________ test_ecn_marking_lossless_prio[multidut_port_info1-test_flow_percent3] _____________________________________________________________________________________________________________
____________________________________________________________________________________________________________ test_ecn_marking_lossless_prio[multidut_port_info1-test_flow_percent4] _____________________________________________________________________________________________________________
____________________________________________________________________________________________________________ test_ecn_marking_lossless_prio[multidut_port_info1-test_flow_percent5] _____________________________________________________________________________________________________________
____________________________________________________________________________________________________________ test_ecn_marking_lossless_prio[multidut_port_info1-test_flow_percent6] _____________________________________________________________________________________________________________
____________________________________________________________________________________________________________ test_ecn_marking_lossless_prio[multidut_port_info2-test_flow_percent0] _____________________________________________________________________________________________________________
____________________________________________________________________________________________________________ test_ecn_marking_lossless_prio[multidut_port_info2-test_flow_percent1] _____________________________________________________________________________________________________________
____________________________________________________________________________________________________________ test_ecn_marking_lossless_prio[multidut_port_info2-test_flow_percent2] _____________________________________________________________________________________________________________
____________________________________________________________________________________________________________ test_ecn_marking_lossless_prio[multidut_port_info2-test_flow_percent3] _____________________________________________________________________________________________________________
____________________________________________________________________________________________________________ test_ecn_marking_lossless_prio[multidut_port_info2-test_flow_percent4] _____________________________________________________________________________________________________________
____________________________________________________________________________________________________________ test_ecn_marking_lossless_prio[multidut_port_info2-test_flow_percent5] _____________________________________________________________________________________________________________
____________________________________________________________________________________________________________ test_ecn_marking_lossless_prio[multidut_port_info2-test_flow_percent6] _____________________________________________________________________________________________________________
____________________________________________________________________________________________________________ test_ecn_marking_lossless_prio[multidut_port_info2-test_flow_percent7] _____________________________________________________________________________________________________________
_____________________________________________________________________________________________________________________ test_ecn_marking_ect_marked_pkts[multidut_port_info0] _____________________________________________________________________________________________________________________
_____________________________________________________________________________________________________________________ test_ecn_marking_ect_marked_pkts[multidut_port_info1] _____________________________________________________________________________________________________________________
_____________________________________________________________________________________________________________________ test_ecn_marking_ect_marked_pkts[multidut_port_info2] _____________________________________________________________________________________________________________________
_____________________________________________________________________________________________________________________ test_ecn_marking_ect_marked_pkts[multidut_port_info3] _____________________________________________________________________________________________________________________
-------------------------------------------------------------------------------------------------------------- generated xml file: /run_logs/ixia/21831/2025-03-25-11-57-36/tr.xml --------------------------------------------------------------------------------------------------------------
INFO:root:Can not get Allure report URL. Please check logs
```

#### Supported testbed topology if it's a new test case?

### Documentation
<!--
(If it's a new feature, new test case)
Did you update documentation/Wiki relevant to your implementation?
Link to the wiki page?
-->
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
Includes the following commits:

1673d25 [y_cable] refactor upgrade firmware API's; Fix vendor and part number API's read size for read_eeprom (sonic-net#174)
ed93a15 [sonic_platform_base] Proper use of class and instance attributes (sonic-net#173)
691de92 [sonic_y_cable] add stub function for upgrade firmware of Y cable and split the get_part_number and get_vendor API's (sonic-net#171)

Signed-off-by: vaibhav-dahiya <[email protected]>
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
c4d4790 [xcvrd] refactor Y-Cable firmware information to conform with all vendors (sonic-net#171)
be7f4e1 [voqinband]Support for inband port as regular port (sonic-net#145)

Signed-off-by: vaibhav-dahiya <[email protected]>
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
…02012 (sonic-net#7314)

- [xcvrd] refactor Y-Cable firmware information to conform with all vendors (sonic-net#171)
- [thermalctld] No need exit thermalcltd when loading invalid policy file (sonic-net#172) <--- branch point

Signed-off-by: Danny Allen <[email protected]>
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
…nux-kernel] advance submodule head (sonic-net#13906)

linkmgrd:
* 3e7a9df 2023-02-19 | [active-active] Toggle to standby if default route is missing (sonic-net#171) (HEAD -> 202205) [Longxiang Lyu]
* 8ab1b2b 2023-02-15 | [active-active] fix issue that interfaces get stuck in `active` if service starts up with link state down (sonic-net#169) [Jing Zhang]
* df862ad 2023-02-11 | Fix mux config when gRPC connection is lost (sonic-net#166) [Longxiang Lyu]

utilities:
* 8aa7930c 2023-02-13 | [portstat CLI] don't print reminder if use json format (sonic-net#2670) (HEAD -> 202205, github/202205) [wenyiz2021]
* 4e3bb6fa 2023-02-21 | Add "show fabric reachability" command. (sonic-net#2672) [jfeng-arista]
* 3587a94b 2023-02-18 | [202205][dhcp_relay] Remove add field of vlanid to DHCP_RELAY table while adding vlan (sonic-net#2680) [Yaqiang Zhu]
* 4f07f7f0 2023-02-10 | Skip saidump for Spine Router as this can take more than 5 sec (sonic-net#2637) (sonic-net#2671) [kenneth-arista]
* e61c5ec4 2023-02-10 | [vlan] Refresh dhcpv6_relay config while adding/deleting a vlan (sonic-net#2660) (sonic-net#2669) [Yaqiang Zhu]

swss:
* 1bbf725 2023-02-14 | [Workaround] EvpnRemoteVnip2pOrch warmboot check failure (sonic-net#2626) (HEAD -> 202205) [jcaiMR]
* 380f72b 2023-02-20 | Support for tc-dot1p and tc-dscp qosmap (sonic-net#2559) [Divya Mukundan]
* dbf6fcc 2022-11-01 | Added LAG member check on addLagMember() (sonic-net#2464) [Andriy Kokhan]

swss-common:
* b31391b 2023-02-21 | Prevent sonic-db-cli generate core dump (sonic-net#749) (HEAD -> 202205) [Hua Liu]
* 16ff689 2022-12-13 | Support for TC-DOT1p qos map (sonic-net#721) [Divya Mukundan]

platform-daemons:
* fb92af4 2023-02-09 | [ycabled] add more coverage to ycabled; add minor name change for vendor API CLI return key-values pairs (sonic-net#338) (HEAD -> 202205) [vdahiya12]

linux-kernel:
* 4e62401 2023-02-09 | Update linux kernel for hw-mgmt V.7.0020.4104 (sonic-net#305) (HEAD -> 202205) [Stephen Sun]

Signed-off-by: Ying Xie <[email protected]>
kazinator-arista pushed a commit to kazinator-arista/sonic-mgmt that referenced this pull request Mar 4, 2026
sonic-net#15576)

#### Why I did it
src/linkmgrd
```
* fc6e299 - (HEAD -> 202211, origin/202211) [active-standby] Enforce switchover based on heartbeats when mux probe keeps failing (sonic-net#184) (2 hours ago) [Jing Zhang]
* 5c6332d - Re-handle pre-init mux config notification after state machine init (sonic-net#202) (2 hours ago) [Longxiang Lyu]
* c49a5ef - [active-standby][bsl] fix no mux probe issue (sonic-net#201) (2 hours ago) [Jing Zhang]
* 2d62ef1 - Enable debug symbols (sonic-net#199) (2 hours ago) [Longxiang Lyu]
* f952b64 - [active-active] Add mux server state correction mechanism (sonic-net#191) (2 hours ago) [Longxiang Lyu]
* e6b1bfc - [ci] fix azure pipeline (sonic-net#190) (2 hours ago) [Jing Zhang]
* 615ed21 - [active-standby] Enforce switchover based on heartbeats when mux probe keeps failing (sonic-net#184) (2 hours ago) [Jing Zhang]
* 3adfc69 - [active-active] add state transition handler for (LinkProber: Unknown, MuxState: Active, LinkState: Down) (sonic-net#179) (2 hours ago) [Jing Zhang]
* 6fb9a0b - loose link down swithcover condition (sonic-net#178) (2 hours ago) [Jing Zhang]
* 8ffbd8a - [ci] Fix apt-get install unable locate package issue. (sonic-net#177) (2 hours ago) [Liu Shilong]
* 3dfbdd7 - [active-active] link operational down didn't trigger toggle to standby if `MuxUnknown` event arrives first.  (sonic-net#175) (2 hours ago) [Jing Zhang]
* 68c06d9 - [active-active] Toggle to standby if default route is missing (sonic-net#171) (2 hours ago) [Longxiang Lyu]
* 1592cd3 - [active-active] fix issue that interfaces get stuck in `active` if service starts up with link state down (sonic-net#169) (2 hours ago) [Jing Zhang]
* a96105f - Fix the warning of unused variables (sonic-net#167) (2 hours ago) [Longxiang Lyu]
* 984ffe3 - Fix mux config when gRPC connection is lost (sonic-net#166) (2 hours ago) [Longxiang Lyu]
* 4d0b457 - [active-active] force switch when config == active && target state == active (sonic-net#164) (2 hours ago) [Jing Zhang]
* 32bd2bb - Use github code scanning instead of LGTM (sonic-net#157) (2 hours ago) [Liu Shilong]
* 6f23fe2 - [active-active] update linkmgr health label definition (sonic-net#163) (3 hours ago) [Jing Zhang]
```
#### How I did it
#### How to verify it
#### Description for the changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants